Hermes - How To Review Patches
-
The patch has to be downloaded, applied, and the code tested, that it builds.
-
All tests must pass.
-
Then you have to look at the patch itself and see if you agree with the changes. This means:
-
You think that it will not break anything in the future.
-
It is well documented what it does.
-
There are tests for the new functionality (important!).
-
Then you have to use your judgment and say what you think about it, and give it +1, or -1.